src/manifest.test.ts (1)

150-151: ⚡ Quick win

Broaden command-link target parsing to avoid brittle false failures.

At Line 150, pipelineCheck\.[A-Za-z]+ is too narrow and can truncate valid command IDs (for example IDs with extra dots/digits). Widening the capture keeps this contract test future-proof.

Suggested diff

-      const targets = [...w.contents.matchAll(/command:(pipelineCheck\.[A-Za-z]+)/g)]
+      const targets = [
+        ...w.contents.matchAll(/command:(pipelineCheck\.[A-Za-z0-9._-]+)/g),
+      ]
         .map((m) => m[1]);

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/manifest.test.ts` around lines 150 - 151, The current extraction for
targets in the test uses a too-narrow regex `command:(pipelineCheck\.[A-Za-z]+)`
which can truncate valid command IDs; update the regex used when building
`targets` (the matchAll call that currently uses `pipelineCheck\.[A-Za-z]+`) to
allow digits, additional dots, underscores, and hyphens (for example
`command:(pipelineCheck[^\s)]+)` or `command:(pipelineCheck\.[\w.-]+)`) so the
full command-id is captured; keep the `.map((m) => m[1])` logic unchanged.

src/statusBar.test.ts (2)

298-301: ⚡ Quick win

Avoid sharing a mutable ExtensionContext across tests.

A module-level ctx lets subscriptions accumulate between test cases, which can mask cleanup regressions and introduce cross-test coupling. Create a fresh context per test (or in beforeEach).

♻️ Suggested change

-  const ctx = {
-    subscriptions: [] as Array<{ dispose?: () => void }>,
-  } as unknown as import("vscode").ExtensionContext;
+  let ctx: import("vscode").ExtensionContext;
+
+  beforeEach(() => {
+    ctx = {
+      subscriptions: [] as Array<{ dispose?: () => void }>,
+    } as unknown as import("vscode").ExtensionContext;
+  });

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/statusBar.test.ts` around lines 298 - 301, The test file currently
defines a module-level ctx object (variable ctx with subscriptions: [] cast to
ExtensionContext) which is shared across tests and allows subscriptions to
accumulate; change tests to create a fresh ExtensionContext for each test (e.g.
instantiate ctx inside each test or in a beforeEach) so the subscriptions array
is reinitialized per test, and update any references to the module-level ctx
variable to use the per-test/local ctx instead to avoid cross-test coupling and
hidden cleanup regressions.

---

386-398: ⚡ Quick win

Strengthen the cleanup assertion to verify the status-bar item is actually subscribed.

The current subs.length >= 1 can pass even if only the diagnostics disposable is registered. Assert that the created item is present in subscriptions.

✅ Suggested assertion improvement

   registerStatusBar(localCtx);
   await tick();
-  // The returned item itself + the onDidChangeDiagnostics disposable
-  // both land here. The item should be one of them.
-  expect(subs.length).toBeGreaterThanOrEqual(1);
+  const item = lastItem();
+  expect(subs).toContain(item);

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/statusBar.test.ts` around lines 386 - 398, The test currently only checks
subs.length but should verify the actual status bar item was pushed; change
registerStatusBar to return the created StatusBarItem (or expose it) and update
the test to capture that return value (e.g. const item =
registerStatusBar(localCtx)) then assert subs.includes(item) (or find the exact
object in subs by identity) so you confirm the status bar item itself was added
to localCtx.subscriptions; reference registerStatusBar, localCtx and subs when
locating code to change.